[PATCH 07/16] board: stm32mp1: Keep error led ON in case of low power detection

Patrice CHOTARD patrice.chotard at st.com
Wed Apr 1 09:44:05 CEST 2020


HI Patrick

On 3/31/20 6:04 PM, Patrick Delaunay wrote:
> From: Patrice Chotard <patrice.chotard at st.com>
>
> Since commit commit dd2810851eb1 ("stm32mp1: board: support of
> error led on ed1/ev1 board") the attended behavior was no more
> respected in case of low power source detection on DK2.
>
> The expected behavior is either the error LED keeps blinking for ever,
> or blinks 2 or 3 times and must stay ON.
>
> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
>
>  board/st/stm32mp1/stm32mp1.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> index 07f5344ec9..8ed09ae24a 100644
> --- a/board/st/stm32mp1/stm32mp1.c
> +++ b/board/st/stm32mp1/stm32mp1.c
> @@ -316,6 +316,7 @@ static void __maybe_unused led_error_blink(u32 nb_blink)
>  			mdelay(125);
>  			WATCHDOG_RESET();
>  		}
> +		led_set_state(led, LEDST_ON);
>  	}
>  #endif
>  

Reviewed-by: Patrice Chotard <patrice.chotard at st.com>

Thanks


More information about the U-Boot mailing list