[PATCH V2 14/14] ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96 board

[Patrick DELAUNAY]

Hi,

> From: Marek Vasut <marex at denx.de>
> Sent: mardi 31 mars 2020 18:38
> 
> On 3/31/20 4:59 PM, Patrick DELAUNAY wrote:
> > Hi,
> 
> Hi,
> 
> >> It is also highly recommended to configure the board for the DHCOM
> >> make stm32mp15_dhcom_basic_defconfig make
> >> DEVICE_TREE=stm32mp15xx-dhcor-
> >> avenger96
> >> as that permits reusing the board code for the DH components, like
> >> accessing and reading out the ethernet MAC from EEPROM.
> >
> > Recommended or mandatory...
> 
> Both work, the later provides more complete solution.

Ok, today both work.

[...]
 
> >> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> >> 9c593b2c98..2564f790de 100644
> >> --- a/arch/arm/dts/Makefile
> >> +++ b/arch/arm/dts/Makefile
> >> @@ -884,7 +884,8 @@ dtb-$(CONFIG_STM32MP15x) += \
> >>  	stm32mp157c-dk2.dtb \
> >>  	stm32mp157c-ed1.dtb \
> >>  	stm32mp157c-ev1.dtb \
> >> -	stm32mp15xx-dhcom-pdk2.dtb
> >> +	stm32mp15xx-dhcom-pdk2.dtb \
> >> +	stm32mp15xx-dhcor-avenger96.dtb
> >
> > Force device tree support for each target ?
> > Avoid to mix incompatible device tree and defconfig....
> >
> > dtb-$(TARGET_ST_STM32MP15x) += \
> > 	stm32mp157a-dk1.dtb \
> >   	stm32mp157c-dk2.dtb \
> >   	stm32mp157c-ed1.dtb \
> >   	stm32mp157c-ev1.dtb
> >
> > dtb-$(TARGET_DH_STM32MP1_PDK2) += \
> > 	stm32mp15xx-dhcom-pdk2.dtb \
> > 	stm32mp15xx-dhcor-avenger96.dtb
> 
> You probably want to build all DTs for STM32MP1 when building STM32MP1
> platforms ?

I use buildman to compile all the stm32mp15x target / defconfig, 
so for me it is not mandatory.

In his makefile, the 2 strategy exist 

	dtb-$(CONFIG_ARCH_....)

	dtb-$(CONFIG_TARGET_....)

I have no clear preference....

I just highlight that using TARGET avoid bad configuration
between defconfig and associated device tree.
 
> [...]
> 
> (please, learn to trim the responses in email)

Yes sorry.

Life is lifelong learning.

> >> -&usbphyc {
> >> -	status = "okay";
> >> -};
> >> -
> >> -&usbphyc_port0 {
> >> -	phy-supply = <&vdd_usb>;
> >> -};
> >> -
> >> -&usbphyc_port1 {
> >> -	phy-supply = <&vdd_usb>;
> >> -};
> >
> > When this file will be removed ? why kept this file.....
> > I propose to completely remove this file (no device tree for same
> > board)
> 
> Backward compatibility, I'd keep it in for a release or two.
> But if removing it is fine, then so be it.

Yes I prefer.
Except if maintainers of this file have a other opinion.

> >> +/* This is kept for backward compatibility and will be removed */
> >> +#include "stm32mp15xx-dhcor-avenger96.dts"
> >
> > Missing u-boot file to avoid issue......
> >
> > +#include " stm32mp15xx-dhcor-avenger96-u-boot.dtsi"
> 
> That's actually included via the avenger96.dts, so should be OK.
> Although I am not real happy with that.

Ok, I miss that. 
I agree, it is unexpected.

Regards

Patrick