[PATCH V3 12/14] ARM: dts: stm32: Repair PMIC configuration on AV96

Patrick DELAUNAY patrick.delaunay at st.com
Wed Apr 1 15:52:23 CEST 2020


Hi,

> From: Marek Vasut <marex at denx.de>
> Sent: mercredi 1 avril 2020 14:53
> To: Patrice CHOTARD <patrice.chotard at st.com>; Patrick DELAUNAY
> <patrick.delaunay at st.com>; u-boot at lists.denx.de; Pascal PAILLET-LME
> <p.paillet at st.com>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>; Alexandre
> TORGUE <alexandre.torgue at st.com>
> Subject: Re: [PATCH V3 12/14] ARM: dts: stm32: Repair PMIC configuration on
> AV96
> Importance: High
> 
> On 4/1/20 2:45 PM, Patrice CHOTARD wrote:
> >
> > On 4/1/20 1:06 PM, Marek Vasut wrote:
> >> On 4/1/20 9:34 AM, Patrick DELAUNAY wrote:
> >>> Hi Marek and Pascal,
> >> Hi,
> >>
> >> [...]
[...]
> >>>>  			vdd: buck3 {
> >>>>  				regulator-name = "vdd";
> >>>> -				regulator-min-microvolt = <3300000>;
> >>>> -				regulator-max-microvolt = <3300000>;
> >>>> +				regulator-min-microvolt = <2900000>;
> >>>> +				regulator-max-microvolt = <2900000>;
> >>>>  				regulator-always-on;
> >>>>  				st,mask_reset;
> >>>>  				regulator-initial-mode = <0>;
> >>>> @@ -268,6 +279,7 @@
> >>>>  				regulator-name = "vbus_otg";
> >>>>  				interrupts = <IT_OCP_OTG 0>;
> >>>>  				interrupt-parent = <&pmic>;
> >>>> +				regulator-active-discharge = <1>;
> >>> It seems this setting introduced other-consumption, it should not be used.
> >> Other-consumption ? What does that mean ?
> >
> > It's a typo, Patrick means over-consumption.
> 
> Ah. Do you have any details on that ?

Sorry for typo.

No details on my side, it was a Pascal Paillet's direct feedback
(Maintainer of STPMIC1 driver in Linux).

Anyway he will review your patch for Linux, with more details,
and I merge this patch without modification for U-Boot.

Patrick


More information about the U-Boot mailing list