[PATCH] spi: cadence-qspi: Move ref clock calculation to probe

Jagan Teki jagan at amarulasolutions.com
Thu Apr 2 14:02:42 CEST 2020


On Wed, Feb 26, 2020 at 1:02 PM Simon Goldschmidt
<simon.k.r.goldschmidt at gmail.com> wrote:
>
>
>
> Vignesh Raghavendra <vigneshr at ti.com> schrieb am Mi., 26. Feb. 2020, 08:29:
>>
>> +Simon who converted driver to use clk_get* APIs
>>
>> On 24/02/20 12:40 pm, Pratyush Yadav wrote:
>> > "assigned-clock-parents" and "assigned-clock-rates" DT properties take
>> > effect only after ofdata_to_platdata() when clk_set_defaults() is called
>> > in device_probe(). Therefore clk get rate() would return a wrong value
>> > in ofdata_to_platdata() when compared with probe. Hence it needs to be
>> > moved to probe.
>> >
>> > Tested on u-boot-ti/next.
>> >
>>
>> Acked-by: Vignesh Raghavendra <vigneshr at ti.com>
>
>
> Fine by me. I actually moved it there after someone requested me to :-) I first had it in the set_rate function...
>
> Acked-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>

So, does this fixing something or will it work even for wrong value?
I'm thinking of picking it up for release, if associated boards got
tested.

Jagan.


More information about the U-Boot mailing list