[PATCH v1 3/8] spi: dw: Rename "cs-gpio" to "cs-gpios"

Sean Anderson seanga2 at gmail.com
Thu Apr 2 14:33:27 CEST 2020

On 4/2/20 8:17 AM, Jagan Teki wrote:
> On Fri, Mar 6, 2020 at 12:49 AM Sean Anderson <seanga2 at gmail.com> wrote:
>> This property is named differently than other SPI drivers with the same
>> property, as well as the property as used in Linux.
>> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
>> ---
>>  arch/arc/dts/axs10x_mb.dtsi  |  3 ++-
>>  arch/arc/dts/hsdk.dts        |  3 ++-
>>  drivers/spi/designware_spi.c | 10 +++-------
> Better separate the dts changes and add sha1 from Linux if it synced.

This is not from a specific patch; I just noticed that it was different
and changed it. I think it is clearer to include dts changes with the
code change. That way if someone is reviewing the device tree, it is
obvious why the change was made. Splitting the changes would also make
the code not run properly for the intermediate commit. This can be
annoying when bisecting. However, if you would still like it split, I
can do that.


More information about the U-Boot mailing list