[PATCH] rockchip: board: roc-pc-rk3399: Remove support for push button
Kever Yang
kever.yang at rock-chips.com
Thu Apr 2 15:02:39 CEST 2020
Hi Sunil, Jagan,
What suppose to be for LEDs status base on this patch and patch[0]?
Thanks,
- Kever
[0] https://patchwork.ozlabs.org/patch/1258094/
<https://patchwork.ozlabs.org/patch/1258094/>
On 2020/4/2 下午8:52, sunil at amarulasolutions.com wrote:
> From: Suniel Mahesh <sunil at amarulasolutions.com>
>
> In case of a power interruption, human intervention is required which
> is not desirable if the device is installed at a remote location. Drop
> yellow LED as it is not much of use. Keep red LED(diy-led) as it is, to
> indicate board in full power mode.
>
> Signed-off-by: Suniel Mahesh <sunil at amarulasolutions.com>
> ---
> Note:
> - patch tested on rk3399-roc-pc
> - code related to button press is removed
> ---
> board/firefly/roc-pc-rk3399/roc-pc-rk3399.c | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/board/firefly/roc-pc-rk3399/roc-pc-rk3399.c b/board/firefly/roc-pc-rk3399/roc-pc-rk3399.c
> index de9185a..0fe1914 100644
> --- a/board/firefly/roc-pc-rk3399/roc-pc-rk3399.c
> +++ b/board/firefly/roc-pc-rk3399/roc-pc-rk3399.c
> @@ -10,7 +10,6 @@
> #include <spl_gpio.h>
> #include <asm/io.h>
> #include <asm/arch-rockchip/gpio.h>
> -#include <asm/arch-rockchip/grf_rk3399.h>
>
> #ifndef CONFIG_SPL_BUILD
> int board_early_init_f(void)
> @@ -34,26 +33,13 @@ out:
>
> #if defined(CONFIG_TPL_BUILD)
>
> -#define PMUGRF_BASE 0xff320000
> #define GPIO0_BASE 0xff720000
>
> int board_early_init_f(void)
> {
> struct rockchip_gpio_regs * const gpio0 = (void *)GPIO0_BASE;
> - struct rk3399_pmugrf_regs * const pmugrf = (void *)PMUGRF_BASE;
>
> - /**
> - * 1. Glow yellow LED, termed as low power
> - * 2. Poll for on board power key press
> - * 3. Once 2 done, off yellow and glow red LED, termed as full power
> - * 4. Continue booting...
> - */
> - spl_gpio_output(gpio0, GPIO(BANK_A, 2), 1);
> -
> - spl_gpio_set_pull(&pmugrf->gpio0_p, GPIO(BANK_A, 5), GPIO_PULL_NORMAL);
> - while (readl(&gpio0->ext_port) & 0x20);
> -
> - spl_gpio_output(gpio0, GPIO(BANK_A, 2), 0);
> + /* Turn on red LED, indicating full power mode */
> spl_gpio_output(gpio0, GPIO(BANK_B, 5), 1);
>
> return 0;
More information about the U-Boot
mailing list