[PATCH 3/3] dm: core: refactor functions reading an u32 from dt

[Simon Glass]

Hi Dario,

On Wed, 1 Apr 2020 at 13:34, <dariobin at libero.it> wrote:
>
>
> > Il 31 marzo 2020 alle 1.57 Simon Glass <sjg at chromium.org> ha scritto:
> >
> >
> > On Sun, 29 Mar 2020 at 10:05, Dario Binacchi <dariobin at libero.it> wrote:
> > >
> > > Now reading a 32 bit value from a device-tree property can be expressed
> > > as reading the first element of an array with a single value.
> > >
> > > Signed-off-by: Dario Binacchi <dariobin at libero.it>
> > >
> > > ---
> > >
> > >  drivers/core/of_access.c | 16 +---------------
> > >  drivers/core/ofnode.c    | 23 ++---------------------
> > >  2 files changed, 3 insertions(+), 36 deletions(-)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > Can you please check the code-size delta in SPL on a suitable board?
>
> I have a black beaglebone available (am335x_evm_defconfig).
>
> u-boot-spl.map generated without applying the refactoring patch
> ....
>  .text.ofnode_read_u32
>                 0x0000000000000000       0x2e drivers/built-in.o
>  .text.ofnode_read_u32_index
>                 0x0000000000000000       0x38 drivers/built-in.o
>  .text.ofnode_read_u32_default
>                 0x0000000000000000       0x12 drivers/built-in.o
>
> u-boot-spl.map genarated with the refactoring patch applied
> ....
>  .text.ofnode_read_u32_index
>                 0x0000000000000000       0x38 drivers/built-in.o
>  .text.ofnode_read_u32
>                 0x0000000000000000        0x8 drivers/built-in.o
>  .text.ofnode_read_u32_default
>                 0x0000000000000000       0x14 drivers/built-in.o

Possibly, but a better test is to build your branch with the patch in:

buildman -b <branch> <board>

Then check the size:

buildman -b <branch> -sS

or function detail:

buildman -b <branch> -sSB

That will give us a true picture for SPL. It will show incremental
size increase with your patch.

See buildman docs for more info.

Regards,
Simon