[PATCH] serial: ns16550: Fix ordering of getting base address

Andy Shevchenko andriy.shevchenko at linux.intel.com
Fri Apr 3 12:56:55 CEST 2020


On Fri, Apr 03, 2020 at 06:16:51PM +0800, Bin Meng wrote:
> On Fri, Apr 3, 2020 at 6:05 PM Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> > On Fri, Apr 03, 2020 at 02:58:08AM -0700, Bin Meng wrote:

...

> > > Fixes: 720f9e1fdb0c9 ("serial: ns16550: Move PCI access from
> > > ofdata_to_platdata() to probe()")
> >
> > I believe this should be one line.
> 
> I thought putting it in one line violates the 80 characters per column
> rule. And checkpatch.pl does not complain about this, so I think it's
> fine :)

Breaking tags to two or more lines actually breaks the scripts around this stuff.

JFYI, in Linux kernel it was now in documentation (not to break Fixes, etc to
two or more lines).

-- 
With Best Regards,
Andy Shevchenko




More information about the U-Boot mailing list