[PATCH v3 27/29] acpi: Put table-setup code in its own function

Andy Shevchenko andriy.shevchenko at linux.intel.com
Fri Apr 3 15:32:53 CEST 2020


On Mon, Mar 30, 2020 at 05:13:03PM -0600, Simon Glass wrote:
> We always write three basic tables to ACPI at the start. Move this into
> its own function, along with acpi_fill_header(), so we can write a test
> for this code.

...

>  	/* Re-calculate checksum */
>  	rsdt->header.checksum = 0;
> -	rsdt->header.checksum = table_compute_checksum((u8 *)rsdt,
> +	rsdt->header.checksum = table_compute_checksum(rsdt,
>  						       rsdt->header.length);

Why suddenly casting is not needed in this patch?
Same question to the rest.

(If it's a valid change, it should be in a separate patch)

-- 
With Best Regards,
Andy Shevchenko




More information about the U-Boot mailing list