[PATCH v5 17/20] spl: nor: add lzma decompression support for legacy image

[Stefan Roese]

Hi,

On 13.02.20 08:55, Simon Goldschmidt wrote:
> On Wed, Feb 12, 2020 at 10:46 AM Weijie Gao <weijie.gao at mediatek.com> wrote:
>>
>> This patch adds support for decompressing LZMA compressed u-boot payload in
>> legacy uImage format.
>>
>> Using this patch together with u-boot-lzma.img is useful for NOR flashes as
>> they can reduce the size and load time of u-boot payload.
>>
>> Reviewed-by: Stefan Roese <sr at denx.de>
>> Signed-off-by: Weijie Gao <weijie.gao at mediatek.com>
>> ---
>> Changes since v3: removed unused code. add description for cache flushing
> 
> This is v5. What has changed since v4?

<snip>

>> +       /* Flush instruction cache */
> 
> Is this "add description for cache flushing" mentioned in the log above? I can
> see from the function name that you're flushing cache. Only I still don't see
> why this is necessary here (but not in the rest of the code where SPL starts a
> U-Boot image).

I just wanted to inform you that I'm working on a patchset, making
this lzma decompression for legacy images more generic. So that this
patchset which is pending for quite a while can be integrated hopefully
in the next merge window.

I'll post the complete patchset in v6 with my changes later today...

Thanks,
Stefan