[PATCH v4 13/31] x86: apl: Add Global NVS table header

Andy Shevchenko andriy.shevchenko at linux.intel.com
Wed Apr 8 19:14:32 CEST 2020


On Tue, Apr 07, 2020 at 09:00:49PM -0600, Simon Glass wrote:
> Add the C version of this header. It includes a few Chrome OS bits which
> are disabled for a normal build.

> +	u8	unused[0x100 - 0x3d];		/* Pad out to 0x100 */
> +	u8	unused2[0x1000 - 0x100];	/* Pad out to 4KB */

Inconsistent size representation in the comment: 256 bytes, 4096 bytes?
Also I would rather name unused1 and unused2.

-- 
With Best Regards,
Andy Shevchenko




More information about the U-Boot mailing list