[PATCH v5 10/29] pci: Adjust dm_pci_read_bar32() to return errors correctly

Andy Shevchenko andy.shevchenko at gmail.com
Thu Apr 9 11:06:11 CEST 2020


On Thu, Apr 9, 2020 at 2:00 AM Simon Glass <sjg at chromium.org> wrote:
>
> At present if reading a BAR returns 0xffffffff (e.g. the device is not
> present) then the value is masked and a different value is returned.
> This makes it harder to detect the problem when debugging.

If you insisting on the code, you may need to reword the commit
message, at least by removing ambiguous "device not present", because
this is not how PCI spec defines situations when device is not
present.

-- 
With Best Regards,
Andy Shevchenko


More information about the U-Boot mailing list