Calling i2c set speed twice for i2c_mux_bus

Michal Simek michal.simek at xilinx.com
Fri Apr 10 08:21:56 CEST 2020


Hi Simon,

On 09. 04. 20 18:25, Simon Glass wrote:
> Hi Michal,
> 
> On Thu, 9 Apr 2020 at 08:03, Michal Simek <michal.simek at xilinx.com> wrote:
>>
>> Hi Heiko and Simon,
>>
>> I have find out one bug in i2c class. I am using zcu104 revC board which
>> has dts in mainline where i2c1 has i2c mux with some channels.
>> In DT clock-frequency = <400000>; is specified and it is read in
>> i2c_post_probe(). But i2c_mux_bus_drv is also UCLASS_I2C which means
>> that post probe is called for it too. And because clock-frequency
>> property is not there default 100k is used.
>>
>> I think that is bug and should be fixed.
>> Heiko: Are you aware about this issue?
>>
>> Simon: I think that make sense to use some flags to skip calling
>> post_probe in this case. Or any suggestion how to fix it would be great.
> 
> Ick, hope not. Can you please point me to the board config and the device tree?


We have switch to generic config for all zynqmp boards.
That's why

export DEVICE_TREE=zynqmp-zcu104-revC
make xilinx_zynqmp_virt_defconfig

It means DT arch/arm/dts/zynqmp-zcu104-revC.dts but I expect the same
behavior on zynqmp-zcu102-revA and others who have i2c mux driver.

Thanks,
Michal



More information about the U-Boot mailing list