[PATCH 08/16] board: stm32mp1: update management of boot-led
Patrick DELAUNAY
patrick.delaunay at st.com
Fri Apr 10 19:08:33 CEST 2020
Dear Anatolij
> From: Anatolij Gustschin <agust at denx.de>
> Sent: mercredi 1 avril 2020 13:43
>
> Hi Patrick,
>
> On Tue, 31 Mar 2020 18:04:25 +0200
> Patrick Delaunay patrick.delaunay at st.com wrote:
> ...
> > @@ -648,8 +652,10 @@ int board_init(void)
> >
> > sysconf_init();
> >
> > - if (CONFIG_IS_ENABLED(CONFIG_LED))
> > + if (CONFIG_IS_ENABLED(CONFIG_LED)) {
> > led_default_state();
>
> Did you verify that this works like expected? We either use
> if (CONFIG_IS_ENABLED(LED))
> or
> if (IS_ENABLED(CONFIG_LED))
>
> Please check.
You are right: it is not working.
I had already make this error,
I will solve the issue a in separate patch (also impacting dh_stm32mp1).
Thanks for review.
> --
> Anatolij
Patrick
More information about the U-Boot
mailing list