[PATCH 5/8] xhci: mediatek: Add support for MTK xHCI host controller

Marek Vasut marex at denx.de
Fri Apr 10 21:27:32 CEST 2020

On 4/10/20 9:14 PM, Simon Glass wrote:
> Hi Marek,


> On Fri, 10 Apr 2020 at 12:45, Marek Vasut <marex at denx.de> wrote:
>> On 3/31/20 6:05 PM, Marek Vasut wrote:
>>> On 3/31/20 4:16 PM, Simon Glass wrote:
>>>> HI Marek,
>>> Hi,
>>> [...]
>>>>>>>> OK I have updated the coding style page with all of this.
>>>>>>> Which page ?
>>>>>> https://www.denx.de/wiki/U-Boot/CodingStyle
>>>>> " U-Boot typically uses a C structure to map out the registers in an I/O
>>>>> region, rather than offsets. The reasons for this are: " is misleading
>>>>> and suggests that using structures is the best practice. This should be
>>>>> reworded to make it clear both options are equally valid.
>>>> I'd like to see a preference to use struct where it makes sense and
>>>> not use it when it doesn't, with the different tradeoffs clearly
>>>> written. Are asking that we say nothing about which is better in each
>>>> situation?
>>> Correct, because I don't see a clear agreement on which one is better
>>> and should be preferred.
>> I see the wiki has still not been correctly reworded, can you please
>> repair it ?
> What sort of 'repairs' are you thinking of?

 This may need to change to the kernel model if we allow for more
run-time detection of what drivers are appropriate for what we're
running on.

This was removed. I believe this is quite important to leave there.

> I did add your counterpoints but did not change the text in the first
> part, which has been long-standing. I think to do that we really would
> need a wider discussion than just the two of us, particularly as we
> seem not to agree on the 'default' position.


More information about the U-Boot mailing list