[PATCHv2 2/9] arm64: fsl-layerscape: Assign addr to resv_ram if enabled RESV_RAM config

Priyanka Jain (OSS) priyanka.jain at oss.nxp.com
Wed Apr 15 12:27:37 CEST 2020


>-----Original Message-----
>From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Zhiqiang Hou
>Sent: Tuesday, March 24, 2020 1:42 PM
>To: u-boot at lists.denx.de; Priyanka Jain <priyanka.jain at nxp.com>; Biwen Li
><biwen.li at nxp.com>
>Cc: Z.q. Hou <zhiqiang.hou at nxp.com>
>Subject: [PATCHv2 2/9] arm64: fsl-layerscape: Assign addr to resv_ram if
>enabled RESV_RAM config
>
>From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
>
>The initialization of gd->arch.resv_ram pointer should depend on if the
>RESV_RAM config is enabled.
>
>Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
>---
>V2:
> - No change.
>
> arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>index b443894453..1b7729c046 100644
>--- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>+++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>@@ -1379,7 +1379,7 @@ static int tfa_dram_init_banksize(void)
> 	if (i > 0)
> 		ret = 0;
>
>-#if defined(CONFIG_FSL_MC_ENET) && !defined(CONFIG_SPL_BUILD)
>+#if defined(CONFIG_RESV_RAM) && !defined(CONFIG_SPL_BUILD)
> 	/* Assign memory for MC */
> #ifdef CONFIG_SYS_DDR_BLOCK3_BASE
> 	if (gd->bd->bi_dram[2].size >=
>@@ -1402,7 +1402,7 @@ static int tfa_dram_init_banksize(void)
> 				board_reserve_ram_top(gd->bd-
>>bi_dram[0].size);
> 		}
> 	}
>-#endif	/* CONFIG_FSL_MC_ENET */
>+#endif	/* CONFIG_RESV_RAM */
This memory block was intended to be used for MC. That's why earlier check was for "CONFIG_FSL_MC_ENET"
Are we planning to use this block for some other purpose as well?
Also I see "CONFIG_ RESV_RAM" getting defines later in the series.
Will MC will work if the series in applied partially?

Regards
Priyanka
> 	return ret;
> }
>@@ -1465,7 +1465,7 @@ int dram_init_banksize(void)
> 	}
> #endif	/* CONFIG_SYS_MEM_RESERVE_SECURE */
>
>-#if defined(CONFIG_FSL_MC_ENET) && !defined(CONFIG_SPL_BUILD)
>+#if defined(CONFIG_RESV_RAM) && !defined(CONFIG_SPL_BUILD)
> 	/* Assign memory for MC */
> #ifdef CONFIG_SYS_DDR_BLOCK3_BASE
> 	if (gd->bd->bi_dram[2].size >=
>@@ -1488,7 +1488,7 @@ int dram_init_banksize(void)
> 				board_reserve_ram_top(gd->bd-
>>bi_dram[0].size);
> 		}
> 	}
>-#endif	/* CONFIG_FSL_MC_ENET */
>+#endif	/* CONFIG_RESV_RAM */
>
> #ifdef CONFIG_SYS_DP_DDR_BASE_PHY
> #ifdef CONFIG_SYS_DDR_BLOCK3_BASE
>--
>2.17.1



More information about the U-Boot mailing list