[PATCH v2 04/14] board: ls1088ardb: transition to DM_ETH

Priyanka Jain priyanka.jain at nxp.com
Wed Apr 15 14:50:43 CEST 2020


>-----Original Message-----
>From: Ioana Ciornei <ioana.ciornei at nxp.com>
>Sent: Wednesday, March 18, 2020 8:18 PM
>To: Priyanka Jain <priyanka.jain at nxp.com>; joe.hershberger at ni.com; u-
>boot at lists.denx.de
>Cc: Florin Laurentiu Chiculita <florinlaurentiu.chiculita at nxp.com>; Ioana
>Ciornei <ioana.ciornei at nxp.com>
>Subject: [PATCH v2 04/14] board: ls1088ardb: transition to DM_ETH
>
>In case CONFIG_DM_ETH is enabled, no hardcoding is necessary for
>DPAA2 Ethernet devices. Compile out any unnecessary setup when
>CONFIG_DM_ETH is activated.
>Also, force the PCI devices to be enumerated at probe time.
>
>Signed-off-by: Ioana Ciornei <ioana.ciornei at nxp.com>
>---
>Changes in v2:
> - none
>
> board/freescale/ls1088a/eth_ls1088ardb.c | 2 ++
> board/freescale/ls1088a/ls1088a.c        | 5 +++++
> 2 files changed, 7 insertions(+)
>
>diff --git a/board/freescale/ls1088a/eth_ls1088ardb.c
>b/board/freescale/ls1088a/eth_ls1088ardb.c
>index 01f56db0a1bf..f56ce7d9ae8e 100644
>--- a/board/freescale/ls1088a/eth_ls1088ardb.c
>+++ b/board/freescale/ls1088a/eth_ls1088ardb.c
>@@ -18,6 +18,7 @@
> #include <fsl-mc/fsl_mc.h>
> #include <fsl-mc/ldpaa_wriop.h>
>
>+#ifndef CONFIG_DM_ETH
> int board_eth_init(bd_t *bis)
> {
> #if defined(CONFIG_FSL_MC_ENET)
>@@ -95,6 +96,7 @@ int board_eth_init(bd_t *bis)
>
> 	return pci_eth_init(bis);
> }
>+#endif
>
> #if defined(CONFIG_RESET_PHY_R)
> void reset_phy(void)
>diff --git a/board/freescale/ls1088a/ls1088a.c
>b/board/freescale/ls1088a/ls1088a.c
>index 0bd397a0beb6..225e787c7577 100644
>--- a/board/freescale/ls1088a/ls1088a.c
>+++ b/board/freescale/ls1088a/ls1088a.c
>@@ -801,6 +801,11 @@ int board_init(void)  #ifdef CONFIG_FSL_LS_PPA
> 	ppa_init();
> #endif
>+
>+#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH)
>+	pci_init();
>+#endif
>+
Ioana,
Can you please confirm that you have tested e1000 cards to be working fine after this kind of changes.

Tested
Priyanka
> 	return 0;
> }
>
>--
>2.17.1



More information about the U-Boot mailing list