[PATCH v5 14/29] acpi: Add a binding for ACPI settings in the device tree

Andy Shevchenko andy.shevchenko at gmail.com
Wed Apr 15 18:35:37 CEST 2020


On Wed, Apr 15, 2020 at 7:16 PM Wolfgang Wallner
<wolfgang.wallner at br-automation.com> wrote:

> I have learned through the previous review discussions aspects about this
> binding which are not captured in the current patch. I tried to incorporate
> these findings, the modified text is proposed below.
>
> Additionally, I realized that I still don't understand how some parts of the
> proposed binding are intended to work. I have highlighted these aspects with
> a TODO note. Please have a look.
>
> regards, Wolfgang
>
> --------------------------------------------------------------------------
>
> Devices
> =======
>
> Device bindings are described by their own individual binding files.
> U-Boot provides for some optional properties which are documented here.
>
> ACPI-related properties:


>  - acpi,compatible : ACPI devices may report a _HID or _CID of "PRP0001", in
>     which case they are expected to provide a _DSD object with a "compatible"
>     property.

No, this is simple incorrect.
PRP0001 should not be mentioned at all. _DSD() as I said in the other
thread is orthogonal to the ACPI ID.

> The value of this "compatible" property is specified by
>     "acpi,compatible".
>     See also section 6.2.5 of [1] as well as [2-3] for details.
>

>     TODO: will PRP0001 be used as _HID or as _CID?

None. Please, forget about PRP0001.

>     TODO: How does this work togheter with "acpi, compatible"? (assuming
>     "acpi,compatible" implies a _HID of "PRP0001")

Ditto.

-- 
With Best Regards,
Andy Shevchenko


More information about the U-Boot mailing list