[PATCH 2/3] cmd/bedbug.c: Make bedbug_init have a return value

Simon Glass sjg at chromium.org
Mon Apr 20 01:40:10 CEST 2020


On Sat, 18 Apr 2020 at 00:08, Ovidiu Panait <ovpanait at gmail.com> wrote:
>
> Do this as a preparation for removing initr_bedbug wrapper from
> common/board_r.c.
>
> Signed-off-by: Ovidiu Panait <ovpanait at gmail.com>
> ---
>  cmd/bedbug.c          | 4 ++--
>  include/bedbug/type.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>

but see below

> diff --git a/cmd/bedbug.c b/cmd/bedbug.c
> index 9fee528830..7cb6378352 100644
> --- a/cmd/bedbug.c
> +++ b/cmd/bedbug.c
> @@ -44,10 +44,10 @@ int bedbug_puts (const char *str)
>   * settings.
>   * ====================================================================== */
>
> -void bedbug_init (void)
> +int bedbug_init (void)

fix checkpatch warning here and below



>  {
>         /* -------------------------------------------------- */
> -       return;
> +       return 0;
>  }                              /* bedbug_init */
>
>
> diff --git a/include/bedbug/type.h b/include/bedbug/type.h
> index b7b447b1fe..5008b40ca8 100644
> --- a/include/bedbug/type.h
> +++ b/include/bedbug/type.h
> @@ -3,7 +3,7 @@
>
>  /* Supporting routines */
>  int bedbug_puts (const char *);
> -void bedbug_init (void);
> +int bedbug_init (void);
>  void bedbug860_init (void);
>  void do_bedbug_breakpoint (struct pt_regs *);
>  void bedbug_main_loop (unsigned long, struct pt_regs *);
> --
> 2.17.1
>


More information about the U-Boot mailing list