[Patch V4 3/3] configs: rpi_4 : enable SDHCI_SDMA config

[Jaehoon Chung]

Hi,

On 3/30/20 1:19 PM, Jaehoon Chung wrote:
> Hi Matthias,
> 
> On 3/27/20 10:12 PM, Matthias Brugger wrote:
>> Hi Jaehoon,
>>
>> On 27/03/2020 05:08, Jaehoon Chung wrote:
>>> Enable SDHCI_SDMA configuration.
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
>>> Reviewed-by: Peng Fan <peng.fan at nxp.com>
>>> Reviewed-by: Minkyu Kang <mk7.kang at samsung.com>
>>> ---
>>>  configs/rpi_4_32b_defconfig | 1 +
>>>  configs/rpi_4_defconfig     | 1 +
>>>  2 files changed, 2 insertions(+)
>>>
>>
>> Please address the comments I had in v3 of this patch:
>> https://protect2.fireeye.com/url?k=9b37681b-c6e760fe-9b36e354-000babff3563-8e3527bcf915de86&u=https://patchwork.ozlabs.org/patch/1261047/
> 
> Thanks for ping to me. I missed it.
> 
>>
>> If you just send a new version of the patch that won't convince me to take it.
>> We will need to make sure that we are fine with patch. Especially I'm concerned
>> about the limitation of the device to only be able to access the first GiB of
>> RAM for DMA. I'd like to see an explanation why this won't happen on U-Boot.
> 
> It's why used phys_to_bus function.(arch/arm/mach-bcm283x/phys2bus.c)
> It's returned the bus address to access ram with DMA. Based at 0xc0000000 or 0x40000000.

Is there any comment? 

Best Regards,
Jaehoon Chung

> 
> 
> Best Regards,
> Jaehoon Chung
> 
>>
>> Regards,
>> Matthias
>>
>>> diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig
>>> index 72cda5d949..7189914606 100644
>>> --- a/configs/rpi_4_32b_defconfig
>>> +++ b/configs/rpi_4_32b_defconfig
>>> @@ -25,6 +25,7 @@ CONFIG_DFU_MMC=y
>>>  CONFIG_DM_KEYBOARD=y
>>>  CONFIG_DM_MMC=y
>>>  CONFIG_MMC_SDHCI=y
>>> +CONFIG_MMC_SDHCI_SDMA=y
>>>  CONFIG_MMC_SDHCI_BCM2835=y
>>>  CONFIG_DM_ETH=y
>>>  CONFIG_BCMGENET=y
>>> diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig
>>> index 6d148dab07..454d28ea2b 100644
>>> --- a/configs/rpi_4_defconfig
>>> +++ b/configs/rpi_4_defconfig
>>> @@ -25,6 +25,7 @@ CONFIG_DFU_MMC=y
>>>  CONFIG_DM_KEYBOARD=y
>>>  CONFIG_DM_MMC=y
>>>  CONFIG_MMC_SDHCI=y
>>> +CONFIG_MMC_SDHCI_SDMA=y
>>>  CONFIG_MMC_SDHCI_BCM2835=y
>>>  CONFIG_DM_ETH=y
>>>  CONFIG_BCMGENET=y
>>>
>>
>>
> 
> 
>