[PATCH 00/11] Fixes for Nokia RX-51

[Lokesh Vutla]

On 17/04/20 3:27 AM, Pali Rohár wrote:
> On Tuesday 14 April 2020 14:01:44 Pali Rohár wrote:
>> On Tuesday 14 April 2020 17:21:24 Lokesh Vutla wrote:
>>> On 14/04/20 4:47 PM, Pali Rohár wrote:
>>>> On Tuesday 14 April 2020 16:14:08 Lokesh Vutla wrote:
>>>>> On 14/04/20 4:01 PM, Pali Rohár wrote:
>>>>>> On Tuesday 14 April 2020 15:53:14 Lokesh Vutla wrote:
>>>>>>> On 13/04/20 4:11 PM, Pali Rohár wrote:
>>>>>>>> On Wednesday 01 April 2020 00:35:07 Pali Rohár wrote:
>>>>>>>>> This patch series contain fixes for Nokia RX-51 board (aka N900).
>>>>>>>>> After these changes it is possible to run U-Boot in qemu emulator again.
>>>>>>>>> And U-Boot can boot kernel image from RAM, eMMC or OneNAND memory without
>>>>>>>>> problem.
>>>>>>>>>
>>>>>>>>> Pali Rohár (11):
>>>>>>>>>   Nokia RX-51: Update my email address
>>>>>>>>>   Nokia RX-51: Add README.nokia_rx51 file to MAINTAINERS
>>>>>>>>>   Nokia RX-51: Move comment about CONFIG_SYS_TEXT_BASE to correct place
>>>>>>>>>   Nokia RX-51: Move code from defconfig back to C header file
>>>>>>>>>   Nokia RX-51: Revert back onenand defitions
>>>>>>>>>   Nokia RX-51: Remove PART* macros
>>>>>>>>>   Nokia RX-51: Remember setup_console_atag option
>>>>>>>>>   Nokia RX-51: Enable CONFIG_CONSOLE_MUX
>>>>>>>>>   Nokia RX-51: Disable some unused features to decrease size of u-boot
>>>>>>>>>     binary
>>>>>>>>>   Nokia RX-51: Update README.nokia_rx51
>>>>>>>>>   Nokia RX-51: Add automated test for running RX-51 build in qemu
>>>>>>>>
>>>>>>>> Hello! Could you please review this patch series?
>>>>>>>
>>>>>>> Series as such looks good to me. But as I see that thread, this series could not
>>>>>>> boot on real hardware. Is that right?
>>>>>>
>>>>>> Without these patches U-Boot does not boot on both emulated and real HW.
>>>>>> With this patch series U-Boot boots at least on emulated env.
>>>>>>
>>>>>> Older mainline U-Boot version worked fine on both emulated and real HW
>>>>>> so something was broken in U-Boot.
>>>>>
>>>>> So the issue is not completely fixed. Can we get the fix for real hardware
>>>>> included in this series?
>>>>
>>>> I do not have hw equipment for debugging nor I do not know what happened
>>>> that U-Boot stopped working. I already asked for help what happened with
>>>> omap i2c code in u-boot that stopped working but nobody answered me yet.
>>>
>>> I don;t know when it stopped working. But I2C has migrated to Driver-Model. Did
>>> you check if DM_I2C is enabled for nokia rx-51?
>>
>> In .config I do not see any DM_I2C string. Should I something enable?
>> What is needed for OMAP I2C? In .config is:
>>
>> CONFIG_SYS_I2C_OMAP24XX=y
>> CONFIG_SYS_OMAP24_I2C_SLAVE=1
>> CONFIG_SYS_OMAP24_I2C_SPEED=100000
>> CONFIG_SYS_I2C_BUS_MAX=3
> 
> I tried to enable CONFIG_DM and CONFIG_DM_I2C, but it threw following errors:
> 
>   GEN     include/autoconf.mk.dep
> In file included from include/config.h:8,
>                  from ./include/common.h:16:
> include/config_fallbacks.h:51:4: error: #error "Cannot define CONFIG_SYS_I2C when CONFIG_DM_I2C is used"
>  #  error "Cannot define CONFIG_SYS_I2C when CONFIG_DM_I2C is used"
>     ^~~~~
> In file included from include/config.h:8,
>                  from ./include/common.h:16:
> include/config_fallbacks.h:51:4: error: #error "Cannot define CONFIG_SYS_I2C when CONFIG_DM_I2C is used"
>  #  error "Cannot define CONFIG_SYS_I2C when CONFIG_DM_I2C is used"
>     ^~~~~
> 
> Next I tried to remove CONFIG_SYS_I2C from include/configs/nokia_rx51.h but it threw another error:
> 
> board/nokia/rx51/rx51.c: In function ‘rx51_kp_tstc’:
> board/nokia/rx51/rx51.c:628:3: warning: implicit declaration of function ‘i2c_read’; did you mean ‘mmc_read’? [-Wimplicit-function-declaration]
>    i2c_read(TWL4030_CHIP_KEYPAD,

I guess it should be dm_i2c_read(). Also do you have plat_data or DT enabled on
your board? I mean either of those are needed to probe the driver.

Thanks and regards,
Lokesh

>    ^~~~~~~~
>    mmc_read
> 
> arm-linux-gnueabi-ld.bfd: board/nokia/rx51/built-in.o: in function `rx51_kp_tstc':
> /home/pali/develop/u-boot/u-boot/board/nokia/rx51/rx51.c:628: undefined reference to `i2c_read'
> 
> So looks like that CONFIG_DM_I2C is not possible to use it right now.
> 
>> But strange is that there is no problem in qemu emulator without any
>> crash.
>>
>>> Thanks and regards,
>>> Lokesh
>>>
>>>>