[PATCH] usb: ether: avoid NULL check before free()

Marek Vasut marex at denx.de
Mon Apr 20 03:43:11 CEST 2020


On 4/19/20 12:11 PM, Heinrich Schuchardt wrote:
> free() checks if its argument is NULL. Do not duplicate this check.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  drivers/usb/gadget/ether.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
> index a118283984..8533abfd93 100644
> --- a/drivers/usb/gadget/ether.c
> +++ b/drivers/usb/gadget/ether.c
> @@ -2472,8 +2472,7 @@ static int _usb_eth_send(struct ether_priv *priv, void *packet, int length)
>  		}
>  		usb_gadget_handle_interrupts(0);
>  	}
> -	if (rndis_pkt)
> -		free(rndis_pkt);
> +	free(rndis_pkt);
> 
>  	return 0;
>  drop:
> --
> 2.25.1

Applied, thanks.


More information about the U-Boot mailing list