[PATCH] spi: mpc8xxx_spi: fix missing dev_err definition

Rasmus Villemoes rasmus.villemoes at prevas.dk
Mon Apr 20 16:13:41 CEST 2020

The build currently fails with

drivers/spi/mpc8xxx_spi.c:64:3: warning: implicit declaration of function ‘dev_err’ [-Wimplicit-function-declaration]
drivers/spi/built-in.o: In function `mpc8xxx_spi_set_speed':
drivers/spi/mpc8xxx_spi.c:227: undefined reference to `dev_err'

Fixes: 4856cc7a97 (mpc8xxx_spi: implement real ->set_speed)
Fixes: 1a7b462dee (mpc8xxx_spi: put max_cs to use)
Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
Those patches got into -rc5, but I hadn't noticed commit 336d4615f8fa
(dm: core: Create a new header file for 'compat' features) from
-rc2. Sorry about this. Probably no buildbot caught it before release
because no in-tree defconfig sets CONFIG_MPC8XXX_SPI=y.

 drivers/spi/mpc8xxx_spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
index 1bde31ad34..e48debb045 100644
--- a/drivers/spi/mpc8xxx_spi.c
+++ b/drivers/spi/mpc8xxx_spi.c
@@ -12,6 +12,7 @@
 #include <spi.h>
 #include <asm/mpc8xxx_spi.h>
 #include <asm-generic/gpio.h>
+#include <dm/device_compat.h>
 enum {
 	SPI_EV_NE = BIT(31 - 22),	/* Receiver Not Empty */

More information about the U-Boot mailing list