[PATCH] env: make file-scope env_ptr variables static

Tom Rini trini at konsulko.com
Tue Apr 21 14:25:40 CEST 2020

On Tue, Feb 18, 2020 at 08:54:09AM +0000, Rasmus Villemoes wrote:

> The combination ENV_IS_IN_NVRAM=y, ENV_IS_IN_REMOTE=y fails to build:
> env/remote.o:/mnt/ext4/devel/u-boot/env/remote.c:17: multiple definition of `env_ptr'
> env/nvram.o:/mnt/ext4/devel/u-boot/env/nvram.c:41: first defined here
> It's not necessarily a meaningful combination, but for build-testing
> it's nice to be able to enable most ENV_IS_IN_* at the same time, and
> since these env_ptr are not declared anywhere, they really have no
> reason to have external linkage.
> nand.c and flash.c similarly already define file-scope static env_ptr
> variables.
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>

Applied to u-boot/master, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200421/d360ad0d/attachment.sig>

More information about the U-Boot mailing list