Antwort: Re: [PATCH v7 1/9] acpi: Add a binding for ACPI settings in the device tree

[Wolfgang Wallner]

Hi Bin,

-----"Bin Meng" <bmeng.cn at gmail.com> schrieb: -----

>Betreff: Re: [PATCH v7 1/9] acpi: Add a binding for ACPI settings in
>the device tree
>
>Hi Wolfgang, Andy,
>
>On Mon, Apr 20, 2020 at 4:37 AM Simon Glass <sjg at chromium.org> wrote:
>>
>> Devices need to report various identifiers in the ACPI tables.
>Rather than
>> hard-coding these in drivers it is typically better to put them in
>the
>> device tree.
>>
>> Add a binding file to describe this.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>
>Do you have any comments against this patch?

I'm fine with the patch as it is.

However, two remarks:

 1) I proposed some rewording in [1].
    I'm fine with dropping it, I just point it out to make sure
    that it is deliberately dropped and no just overseen.

 2) In [2] Andy stated that "acpi,compatible" can't work.
    @Andy: did I get this wrong? Is it still fine to add it in
    the binding?

regards, Wolfgang

[1] https://lists.denx.de/pipermail/u-boot/2020-April/406818.html
[2] https://lists.denx.de/pipermail/u-boot/2020-April/406943.html