[PATCH v1 2/2] cmd: bind: allow to bind driver with driver data

Simon Glass sjg at chromium.org
Tue Apr 21 19:36:34 CEST 2020


Hi Patrice,

On Tue, 21 Apr 2020 at 08:09, Patrice Chotard <patrice.chotard at st.com> wrote:
>
> Initial implementation invokes device_bind_with_driver_data()
> with driver_data parameter equal to 0.
> For driver with driver data, the bind command can't bind
> correctly this driver or even worse causes data abort.
>
> Add find_udevice_id() to parse the driver's of_match list
> and return the entry corresponding to the driver compatible string.
> This allows to get access to driver_data and to use it as
> parameters of device_bind_with_driver_data().
>
> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
> Cc: Jean-Jacques Hiblot <jjhiblot at ti.com>
>
> ---
>
>  cmd/bind.c | 29 ++++++++++++++++++++++++++++-
>  1 file changed, 28 insertions(+), 1 deletion(-)
>

The thing I don't quite get here is why the driver name needs to be
specified. If the device tree node is present, and it has a compatible
string, can't DM find the driver and bind a device automatically?

Also, is there any docs for this command? It would be good to add to
doc/driver-model and also add a simple test.

Regards,
Simon


More information about the U-Boot mailing list