[RFC PATCH 1/9] usb: xhci: Add missing cache flush in the scratchpad array initialization

Bin Meng bmeng.cn at gmail.com
Wed Apr 22 07:44:44 CEST 2020


On Wed, Apr 22, 2020 at 12:51 AM Sylwester Nawrocki
<s.nawrocki at samsung.com> wrote:
>
> In current code there is no cache flush after initializing the scratchpad
> buffer array with the scratchpad buffer pointers. This leads to a failure
> of the "slot enable" command on the rpi4 board (Broadcom STB PCIe
> controller + VL805 USB hub) - the very first TRB transfer on the command
> ring fails and there is a timeout while waiting for the command completion
> event. After adding the missing cache flush everything seems to be working
> as expected.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki at samsung.com>
> ---
>  drivers/usb/host/xhci-mem.c | 3 +++
>  1 file changed, 3 insertions(+)
>

Good catch!

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list