[PATCH 2/2] drivers: usb: musb: Fix comparison between pointer and integer warn

Marek Vasut marex at denx.de
Wed Apr 22 12:53:30 CEST 2020


On 4/22/20 12:50 PM, Arnaud Ferraris wrote:
> From: Adrian Ratiu <adrian.ratiu at collabora.com>
> 
> drivers/usb/musb-new/ti-musb.c: In function 'ti_musb_ofdata_to_platdata':
> drivers/usb/musb-new/ti-musb.c:93:30: warning: comparison between pointer and integer
> 	if (platdata->ctrl_mod_base == FDT_ADDR_T_NONE) {}
> 
> Signed-off-by: Adrian Ratiu <adrian.ratiu at collabora.com>
> Signed-off-by: Arnaud Ferraris <arnaud.ferraris at collabora.com>
> ---
> 
>  drivers/usb/musb-new/ti-musb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb-new/ti-musb.c b/drivers/usb/musb-new/ti-musb.c
> index 4e88652433..0c124a2c5e 100644
> --- a/drivers/usb/musb-new/ti-musb.c
> +++ b/drivers/usb/musb-new/ti-musb.c
> @@ -91,7 +91,7 @@ static int ti_musb_ofdata_to_platdata(struct udevice *dev)
>  	phys = fdtdec_lookup_phandle(fdt, node, "phys");
>  	ctrl_mod = fdtdec_lookup_phandle(fdt, phys, "ti,ctrl_mod");
>  	platdata->ctrl_mod_base = (void *)fdtdec_get_addr(fdt, ctrl_mod, "reg");
> -	if (platdata->ctrl_mod_base == FDT_ADDR_T_NONE) {
> +	if (platdata->ctrl_mod_base == (void *)FDT_ADDR_T_NONE) {
>  		pr_err("MUSB ctrl mod missing\n");

Is this patching the same code as 1/2 ?


More information about the U-Boot mailing list