[RFC PATCH 1/3] net: phy: Add a generic phy file for TI generic PHYs
grygorii.strashko at ti.com
Wed Apr 22 18:04:21 CEST 2020
On 21/04/2020 14:48, Dan Murphy wrote:
> On 4/21/20 2:57 AM, Michal Simek wrote:
>> On 20. 04. 20 20:53, Dan Murphy wrote:
>>> Add a TI Generic init file that will initialize TI PHYs that follow that
>>> not require special handling. These PHYs can connect with the standard
>>> MII register set. This generice file will register the PHY IDs and
>>> names of the PHYs so when the command 'mdio list' is executed the PHY
>>> name will display as opposed to 'Generic PHY'.
>>> The DP8382X PHY series is a generic PHY that requires the generic
>>> The DP83867 driver was updated to rename the init to a more PHY specific
>>> init call.
>>> Signed-off-by: Dan Murphy <dmurphy at ti.com>
>> I would personally do it with two patches.
> I was going to do 2 patches but I wanted to show the viability of why this generic file was needed. Without the DP8382X PHY added it looks like I was just moving things around for the DP83867 and changing names.
> I will break it up in v2 (non-RFC if no one has serious objections to this)
>>> configs/am65x_evm_a53_defconfig | 2 +-
>>> configs/am65x_hs_evm_a53_defconfig | 2 +-
>>> configs/dra7xx_evm_defconfig | 2 +-
>>> configs/dra7xx_hs_evm_defconfig | 2 +-
>>> configs/dra7xx_hs_evm_usb_defconfig | 2 +-
>>> configs/j721e_evm_a72_defconfig | 2 +-
>>> configs/j721e_hs_evm_a72_defconfig | 2 +-
>>> configs/k2g_evm_defconfig | 2 +-
>>> configs/xilinx_versal_virt_defconfig | 2 +-
>>> configs/xilinx_zynqmp_virt_defconfig | 2 +-
>>> drivers/net/phy/Kconfig | 8 ++
>>> drivers/net/phy/Makefile | 3 +-
>>> drivers/net/phy/dp83867.c | 3 +-
>>> drivers/net/phy/ti_phy_init.c | 106 +++++++++++++++++++++++++++
>>> drivers/net/phy/ti_phy_init.h | 16 ++++
>>> 15 files changed, 144 insertions(+), 12 deletions(-)
>>> create mode 100644 drivers/net/phy/ti_phy_init.c
>>> create mode 100644 drivers/net/phy/ti_phy_init.h
>>> diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
>>> index 542bbd992c53..7051d6c40505 100644
>>> --- a/configs/am65x_evm_a53_defconfig
>>> +++ b/configs/am65x_evm_a53_defconfig
>>> @@ -101,7 +101,7 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT
>>> # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
>> Don't know why this name was chosen but don't you want to label it with TI?
>> CONFIG_PHY_TI_DP83867 ?
>> Kernel is using different symbol anyway.
> ACK. I will make it CONFIG_PHY_TI_DP83867. That follows the Kconfig uBoot standard for PHYs
yep. It definitely has to be split
More information about the U-Boot