[PATCH v7 7/9] acpi: Put table-setup code in its own function

Bin Meng bmeng.cn at gmail.com
Thu Apr 23 11:38:40 CEST 2020


Hi Simon, Wolfgang,

On Mon, Apr 20, 2020 at 4:37 AM Simon Glass <sjg at chromium.org> wrote:
>
> We always write three basic tables to ACPI at the start. Move this into
> its own function, along with acpi_fill_header(), so we can write a test
> for this code.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>

I see Wolfgang gave a RB tag to the v5 patch, so I am going to add
that tag here since no changes between v5 and v7

Reviewed-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>

But I wonder why this new series is tagged as v7. Do I miss v6?

> ---
>
> Changes in v7: None
> Changes in v5: None
> Changes in v4:
> - Put back cast on table_compute_checksum()
>
> Changes in v3:
> - Fix 'XDST' typo
> - Move acpi_align_large() out of dm_test_acpi_setup_base_tables()
> - Beef up the comment explaining how the unaligned address is used
>
> Changes in v2: None
>
>  arch/x86/lib/acpi_table.c | 72 +-----------------------------------
>  include/acpi/acpi_table.h | 10 +++++
>  lib/acpi/acpi_table.c     | 77 +++++++++++++++++++++++++++++++++++++++
>  test/dm/acpi.c            | 58 ++++++++++++++++++++++++++++-
>  4 files changed, 144 insertions(+), 73 deletions(-)
>

Regards,
Bin


More information about the U-Boot mailing list