[PATCH 1/6] x86: Allow building an SPL image for coreboot

[Simon Glass]

Hi Bin,

On Thu, 23 Apr 2020 at 03:14, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Mon, Apr 6, 2020 at 7:22 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > Coreboot runs in 32-bit mode and cannot run a 64-bit U-Boot. To get around
> > this we can build a combined image with 32-bit SPL and 64-bit U-Boot. Add
> > a build rule and binman definition for this.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  Makefile                          |  6 ++++++
> >  arch/x86/cpu/coreboot/Kconfig     |  1 +
> >  arch/x86/dts/coreboot-u-boot.dtsi | 18 ++++++++++++++++++
> >  3 files changed, 25 insertions(+)
> >  create mode 100644 arch/x86/dts/coreboot-u-boot.dtsi
> >
>
> Can we reuse the arch/x86/dts/u-boot.dtsi to do the same thing? I feel
> creating a new rule in /Makefile is not good.

Not easily.

This one creates an output file specifically for coreboot, which is
quite different from the u-boot.rom we normally create.

We could update the main one to use multiple images, and then we could
#ifdef out the u-boot.rom one when building coreboot. Then we could
add this rule in as well. Would that be better?

Regards,
SImon