[PATCH 2/2] tools/fit-image: print a warning when cmd-line for dtc might be truncated

Sven Roederer devel-sven at geroedel.de
Mon Apr 27 02:08:39 CEST 2020


Signed-off-by: Sven Roederer <devel-sven at geroedel.de>
---
 tools/fit_image.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/fit_image.c b/tools/fit_image.c
index 4aeabbcfe9..88ff093d05 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -17,6 +17,7 @@
 #include "fit_common.h"
 #include "mkimage.h"
 #include <image.h>
+#include <string.h>
 #include <stdarg.h>
 #include <version.h>
 #include <u-boot/crc.h>
@@ -744,6 +745,9 @@ static int fit_handle_file(struct image_tool_params *params)
 		snprintf(cmd, sizeof(cmd), "cp \"%s\" \"%s\"",
 			 params->imagefile, tmpfile);
 	}
+	if (strlen(cmd) >= MKIMAGE_MAX_DTC_CMDLINE_LEN - 1) {
+		fprintf(stderr, "WARNING: command-line for FIT creation might be truncated and will probably fail.\n");
+	}
 
 	if (*cmd && system(cmd) == -1) {
 		fprintf (stderr, "%s: system(%s) failed: %s\n",
-- 
2.20.1



More information about the U-Boot mailing list