[PATCH v3 1/2] sandbox, test: add test for GPIO_HOG function

[Heiko Schocher]

Hello Tom, Patrick,

Am 27.04.2020 um 07:16 schrieb Heiko Schocher:
> Hello Tom,
> 
> Am 24.04.2020 um 19:45 schrieb Tom Rini:
>> On Wed, Feb 05, 2020 at 07:19:58AM +0100, Heiko Schocher wrote:
>>
>>> currently gpio hog function is not tested with "ut dm gpio"
>>> so add some basic tests for gpio hog functionality.
>>>
>>> For this enable GPIO_HOG in sandbox_defconfig, add
>>> in DTS some gpio hog entries, and add testcase in
>>> "ut dm gpio" command.
>>>
>>> Signed-off-by: Heiko Schocher <hs at denx.de>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> This no longer applies cleanly/obviously, please rebase, thanks!
> 
> Done, unfortunately, aristainetos2 does not boot anymore... got:
> 
>     ├─UBOOT (ari-ub)
> │   │    <> ### Connect to "aristainetos" using command: /usr/bin/telnet ts2 7015
> │   │    <> Trying 192.168.1.202...
> │   │    <> Connected to ts2.
> │   │    <> Escape character is '^]'.
> │   │    <> <debug_uart> unrecognized JEDEC id bytes: 00, 00, 00
> │   │    <> *** Warning - spi_flash_probe_bus_cs() failed, using default environment
> │   │    <>
> │   │    <> alloc space exhausted
> │   │    <> alloc space exhausted
> │   │    <> alloc space exhausted
> │   │    <> himport_r: can't insert "loadbootscriptUSB=ext4load usb 0 ${loadaddr} ${script};" into 
> hash table
> │   │    <> alloc space exhausted
> │   │    <> alloc space exhausted
> 
> Seems early SPI NOR detection fails ...
> 
> Have to start bisect, try to find some time...

Ok, commit:

commit 788ea834124bd6169ea10b2d37d5de48a2dd28a0 (bisect-788ea83412)
Author: Patrick Delaunay <patrick.delaunay at st.com>
Date:   Mon Jan 13 11:35:03 2020 +0100

     gpio: add function _dm_gpio_set_dir_flags

     Introduce the function _dm_gpio_set_dir_flags to set dir flags
     without check if the GPIO is reserved.

     Separate the reserved check for "set_dir" and "set_dir_flags".

     This patch is a preliminary step to add new ops.

     Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
     Reviewed-by: Simon Glass <sjg at chromium.org>

breaks the aristainetos2 board ... reverting this patch (and therefore
I needed some more patches to revert as it was a patchseries):

* dbf06f0e6c - (HEAD -> aristainetos-denx) Revert "gpio: add function _gpio_get_value" (vor 5 
Minuten) <Heiko Schocher>
* 5c85a7cc26 - Revert "gpio: add function _dm_gpio_set_dir_flags" (vor 5 Minuten) <Heiko Schocher>
* c226d65d88 - Revert "gpio: add function check_dir_flags" (vor 5 Minuten) <Heiko Schocher>
* 1423a40c69 - Revert "gpio: add helper GPIOD_FLAGS_OUTPUT" (vor 5 Minuten) <Heiko Schocher>
* fb0176450f - Revert "gpio: update dir_flags management" (vor 5 Minuten) <Heiko Schocher>
* 9d74cc5ecb - Revert "gpio: add support of new GPIO direction flag" (vor 5 Minuten) <Heiko Schocher>
* 3bf361c206 - Revert "gpio: add ops to get dir flags" (vor 5 Minuten) <Heiko Schocher>
* beb6d3c2d9 - Revert "gpio: add ops to set dir flags" (vor 5 Minuten) <Heiko Schocher>

And board boots again fine ...

I do not see, why commit 788ea834124bd6169ea10b2d37d5de48a2dd28a0
makes SPI not working anymore ...

Any ideas?

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de