[PATCH v1 00/49] add support for broadcom NS3 soc

[Marek Vasut]

On 4/27/20 12:47 PM, Rayagonda Kokatanur wrote:
> This patch series adds support for Broadcom Northstar 3 SoC.

Please, do keep the CC sane, don't CC everyone.

[...]

>  arch/arm/Kconfig                              |  10 +
>  arch/arm/cpu/armv8/Makefile                   |   1 +
>  arch/arm/cpu/armv8/bcmns3/Makefile            |   5 +
>  arch/arm/cpu/armv8/bcmns3/lowlevel.S          |  99 ++
>  arch/arm/dts/Makefile                         |   2 +
>  arch/arm/dts/ns3-board.dts                    | 105 ++
>  arch/arm/dts/ns3-clock.dtsi                   |  34 +
>  arch/arm/dts/ns3-pinctrl.dtsi                 | 321 +++++++
>  arch/arm/dts/ns3.dtsi                         | 265 ++++++
>  arch/arm/include/asm/arch-bcmns3/bl33_info.h  |  26 +
>  arch/arm/include/asm/gpio.h                   |   2 +-
>  board/broadcom/bcmns3/Kconfig                 |  25 +
>  board/broadcom/bcmns3/Makefile                |   7 +
>  board/broadcom/bcmns3/chimp_optee.c           | 154 +++
>  board/broadcom/bcmns3/fit/keys/dev.crt        |  21 +
>  board/broadcom/bcmns3/fit/keys/dev.key        |  28 +
>  board/broadcom/bcmns3/fit/multi.its           |  59 ++
>  board/broadcom/bcmns3/mcu_cmd.c               |  49 +
>  board/broadcom/bcmns3/mcu_cmd.h               |  13 +
>  board/broadcom/bcmns3/ns3.c                   | 263 +++++
>  cmd/Kconfig                                   |   2 +
>  cmd/Makefile                                  |   2 +
>  cmd/bcm/Kconfig                               |  12 +
>  cmd/bcm/Makefile                              |   7 +
>  cmd/bcm/chimp_boot.c                          |  36 +
>  cmd/bcm/chimp_handshake.c                     |  32 +
>  cmd/bcm/elog.h                                |  64 ++
>  cmd/bcm/logsetup.c                            | 432 +++++++++
>  cmd/bcm/nitro_image_load.c                    |  99 ++
>  cmd/gpt.c                                     |  95 ++

Please split the series into multiple smaller, logical series -- core
code, drivers, other stuff. Patching common code should be done in a
separate patchset. Also, these custom commands will need to be rethought.

>  common/Kconfig                                |   8 +
>  common/Makefile                               |   1 +
>  common/bcm_elog.c                             |  49 +
>  common/console.c                              |  22 +
>  configs/bcm_ns3_defconfig                     |  57 ++
>  include/bcm_elog.h                            |  37 +
>  include/brcm/chimp.h                          |  48 +
>  include/configs/bcm_ns3.h                     | 901 ++++++++++++++++++
>  include/dt-bindings/memory/bcm-ns3-mc.h       |  65 ++
>  .../dt-bindings/pinctrl/brcm,pinctrl-ns3.h    |  41 +
>  40 files changed, 3498 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/cpu/armv8/bcmns3/Makefile
>  create mode 100644 arch/arm/cpu/armv8/bcmns3/lowlevel.S
>  create mode 100644 arch/arm/dts/ns3-board.dts
>  create mode 100644 arch/arm/dts/ns3-clock.dtsi
>  create mode 100644 arch/arm/dts/ns3-pinctrl.dtsi
>  create mode 100644 arch/arm/dts/ns3.dtsi
>  create mode 100644 arch/arm/include/asm/arch-bcmns3/bl33_info.h
>  create mode 100644 board/broadcom/bcmns3/Kconfig
>  create mode 100644 board/broadcom/bcmns3/Makefile
>  create mode 100644 board/broadcom/bcmns3/chimp_optee.c
>  create mode 100644 board/broadcom/bcmns3/fit/keys/dev.crt
>  create mode 100644 board/broadcom/bcmns3/fit/keys/dev.key
>  create mode 100644 board/broadcom/bcmns3/fit/multi.its
>  create mode 100644 board/broadcom/bcmns3/mcu_cmd.c
>  create mode 100644 board/broadcom/bcmns3/mcu_cmd.h
>  create mode 100644 board/broadcom/bcmns3/ns3.c
>  create mode 100644 cmd/bcm/Kconfig
>  create mode 100644 cmd/bcm/Makefile
>  create mode 100644 cmd/bcm/chimp_boot.c
>  create mode 100644 cmd/bcm/chimp_handshake.c
>  create mode 100644 cmd/bcm/elog.h
>  create mode 100644 cmd/bcm/logsetup.c
>  create mode 100644 cmd/bcm/nitro_image_load.c
>  create mode 100644 common/bcm_elog.c
>  create mode 100644 configs/bcm_ns3_defconfig
>  create mode 100644 include/bcm_elog.h
>  create mode 100644 include/brcm/chimp.h
>  create mode 100644 include/configs/bcm_ns3.h
>  create mode 100644 include/dt-bindings/memory/bcm-ns3-mc.h
>  create mode 100644 include/dt-bindings/pinctrl/brcm,pinctrl-ns3.h
> 

[...]