[PATCH 3/6] arm: dts: lx2160aqds: add nodes describing possible mezzanine cards

Ioana Ciornei ioana.ciornei at nxp.com
Mon Apr 27 14:00:09 CEST 2020


[snip]

> > >diff --git a/arch/arm/dts/fsl-lx2160a-qds.dtsi
> > >b/arch/arm/dts/fsl-lx2160a- qds.dtsi new file mode 100644 index
> > >000000000000..129cf82a8f37
> > >--- /dev/null
> > >+++ b/arch/arm/dts/fsl-lx2160a-qds.dtsi
> > <snip>
> >
> > Is there any particular reason of adding dpmac related changes in one
> > file in previous patch And then putting in another fie in next patch.
> > Cant we squash this change with the previous patch?
> >
> 
> Not a particular strong reason, I was just thinking that it's cleaner.
> 
> I'll squash them.
> 

On a second look, I would prefer to keep them as is because one could easily see what DTS changes are needed to add support for a new protocol and the changes in patch 3/6 are an example of that.

Ioana

> Thanks,
> Ioana
> 
> > Regards
> > Priyanka


More information about the U-Boot mailing list