[PATCH v2 1/2] arm: dts: bcm283x: Allow UARTs to work before relocation

Matthias Brugger mbrugger at suse.com
Thu Apr 30 11:37:59 CEST 2020


Hi all,

On 29/04/2020 22:11, Simon Glass wrote:
> Hi Tom,
> 
> On Wed, 15 Apr 2020 at 13:59, Tom Rini <trini at konsulko.com> wrote:
>>
>> On Tue, Apr 14, 2020 at 08:23:10PM -0600, Simon Glass wrote:
>>> Hi,
>>>
>>> On Sun, 22 Mar 2020 at 21:16, Simon Glass <sjg at chromium.org> wrote:
>>>>
>>>> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
>>>> the UARTs do not correctly select the pinconfig to enable the UART pins.
>>>> Fix this so that the U-Boot banner is printed.
>>>>
>>>> This fixes serial output on rpi_3b_32b with the following config.txt
>>>> options:
>>>>
>>>>    enable_uart=1
>>>>    gpu_freq=250
>>>>
>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
>>>> ---
>>>>
>>>> Changes in v2:
>>>> - Update commit message
>>>>
>>>>  arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
>>>>  1 file changed, 8 insertions(+)
>>>
>>> Any thoughts on this series? At present all my lab tests fail.
>>
>> I don't know if the problem is my firmware is too old (and so works) or
>> your firmware is too old (and so fails) or if there's some
>> phase-of-the-moon problem.  So while I'd like to know _why_ my 3B is
>> fine and yours is not, we should just take this I suppose.
> 
> It should not harm anything.
> 
> For now I am unable to run rpi tests on mainline.
> 

Sorry for being silent for such a long time. I'll have a look and provide a PR.

Regards,
Matthias


More information about the U-Boot mailing list