[PATCH v2 3/3] net: phy: Add DP8382x phy registration to TI PHY init

[Michal Simek]

On 30. 04. 20 13:47, Dan Murphy wrote:
> Michal
> 
> On 4/30/20 3:04 AM, Michal Simek wrote:
>> On 28. 04. 20 21:26, Dan Murphy wrote:
>>> Add the DP8382X generic PHY registration to the TI PHY init file.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy at ti.com>
>>> ---
>>>   drivers/net/phy/ti_phy_init.c | 91 +++++++++++++++++++++++++++++++++++
>>>   1 file changed, 91 insertions(+)
>>>
>>> diff --git a/drivers/net/phy/ti_phy_init.c
>>> b/drivers/net/phy/ti_phy_init.c
>>> index 277b29a26342..47f32a528361 100644
>>> --- a/drivers/net/phy/ti_phy_init.c
>>> +++ b/drivers/net/phy/ti_phy_init.c
>>> @@ -7,12 +7,103 @@
>>>    * Copyright (C) 2019-20 Texas Instruments Inc.
>>>    */
>>>   +
>> Useless change.
> Ack
>>> +#include <phy.h>
>>>   #include "ti_phy_init.h"
>>>   +#define DP83822_PHY_ID            0x2000a240
>>> +#define DP83825S_PHY_ID        0x2000a140
>>> +#define DP83825I_PHY_ID        0x2000a150
>>> +#define DP83825CM_PHY_ID    0x2000a160
>>> +#define DP83825CS_PHY_ID    0x2000a170
>>> +#define DP83826C_PHY_ID        0x2000a130
>>> +#define DP83826NC_PHY_ID    0x2000a110
>> nit: Can't see value to have these macros here.
> 
> Are you saying to just add the PHY IDs directly below?

others are doing that that's why I can't see the reason to do it
differently. Also normally when you look for phy id you likely want to
know what functions are called.

M