[PATCH] armv8: fsl-layerscape: Fix automatic setting of bootmcd with TF-A

Priyanka Jain priyanka.jain at nxp.com
Fri Dec 11 08:56:17 CET 2020


>-----Original Message-----
>From: Alban Bedel <alban.bedel at aerq.com>
>Sent: Tuesday, November 17, 2020 8:50 PM
>To: u-boot at lists.denx.de
>Cc: Priyanka Jain <priyanka.jain at nxp.com>; Pankit Garg
><pankit.garg at nxp.com>; Bedel, Alban <alban.bedel at aerq.com>
>Subject: [PATCH] armv8: fsl-layerscape: Fix automatic setting of bootmcd with
>TF-A
>
>When booting from TF-A there is a logic that attempt to detect if the default
>environment is used, if this is the case it then set the `bootcmd` and
>`mcinitcmd` depending of the device we booted from.
>This detection logic is dubious as it access internals of the env implementation
>and it doesn't always work correctly.
>
>First of all it detect any valid environment as not being the default, so after
>running `env default -a && saveenv` the board doesn't boot anymore as
>`bootcmd` is then empty.
>But it also fails in some other ways, for example it always detect a default
>environment when redundant env is enabled on MMC, so in that case
>`bootcmd` is overwritten on every boot.
>
>Instead of increasing the complexity of the detection just check if `bootcmd`
>and `mcinitcmd` are set in the environment and set them if they are not.
>
>Signed-off-by: Alban Bedel <alban.bedel at aerq.com>
>---
<snip>
Applied to fsl-qoriq. 
Awaiting upstream

Regards
Priyanka


More information about the U-Boot mailing list