[PATCH 0/9] dm: treewide: Tidy up and adjust driver model naming

Simon Glass sjg at chromium.org
Fri Dec 11 22:30:56 CET 2020


Hi,

On Thu, 3 Dec 2020 at 16:55, Simon Glass <sjg at chromium.org> wrote:
>
> There are several naming problems in driver model which I think are worth
> sorting out.
>
> FIrstly, the _auto_alloc_size suffix is widely used but is quite
> long-winded. In earlier days it made some sense since auto allocation was
> a strange concept. But with driver model now used pretty universally, we
> can shorten this to 'auto'. This reduces verbosity and makes the code
> easier to read.
>
> Secondly, in newer code we use 'priv' (rather than privdata) and 'plat'
> for private data but this is not consistent. In many places 'platdata' is
> used for platform data. We can't really use 'pdata' since that is
> ambiguous (it could mean private or platform data). So this series
> standardises on 'plat'.
>
> Finally, ofdata_to_platdata is shortened to of_to_plat since the 'data'
> bits are redundant.
>
> These changes apply tree-wide. The series is available at u-boot-dm/auto
>
>
> Simon Glass (9):
>   dtoc: Tidy up more Python style in dtb_platdata
>   dm: treewide: Rename auto_alloc_size members to be shorter
>   dm: treewide: Rename 'platdata' variables to just 'plat'
>   dm: Rename 'platdata_size' to 'plat_size'
>   dm: treewide: Rename dev_get_platdata() to dev_get_plat()
>   dm: treewide: Rename ofdata_to_platdata() to of_to_plat()
>   dm: treewide: Update 'auto' declarations to be on one line
>   dm: treewide: Rename ..._platdata variables to just ..._plat
>   checkpatch: Add warnings for unexpected struct names

Any thoughts on this rename? I'd like to apply it before it gets too stale.

Regards,
Simon


More information about the U-Boot mailing list