[PATCH] usb: dwc3-meson-g12a: always configure dr-mode

Marek Szyprowski m.szyprowski at samsung.com
Mon Dec 14 12:34:19 CET 2020


dwc3_meson_g12a_force_mode() sets the dr-mode of the USB PHY. However
it skips setting the mode if it matches the one done during driver probe
(stored in private structure). This fails if the mode has been changed
to other value and then back to initial one. Fix this by configuring the
dr-mode always, regadless of the one set at the driver probe).

This fixes operation of USB gadget based drivers when they are initialized
for the second time.

Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
---
 drivers/usb/dwc3/dwc3-meson-g12a.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
index 6567502cdd1..6f0bac2a00c 100644
--- a/drivers/usb/dwc3/dwc3-meson-g12a.c
+++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
@@ -269,9 +269,6 @@ int dwc3_meson_g12a_force_mode(struct udevice *dev, enum usb_dr_mode mode)
 	if (!priv->phys[USB2_OTG_PHY].dev)
 		return -EINVAL;
 
-	if (mode == priv->otg_mode)
-		return 0;
-
 	if (mode == USB_DR_MODE_HOST)
 		debug("%s: switching to Host Mode\n", __func__);
 	else
-- 
2.17.1



More information about the U-Boot mailing list