[PATCH v2] fsp: Move and rename fsp_types.h file

[Sughosh Ganu]

hi Simon,

On Tue, 15 Dec 2020 at 09:25, Simon Glass <sjg at chromium.org> wrote:

> Hi Sughosh,
>
> On Sun, 13 Dec 2020 at 23:23, Sughosh Ganu <sughosh.ganu at linaro.org>
> wrote:
> >
> > The fsp_types.h header file contains macros for building signatures of
> > different widths. These signature macros are architecture agnostic,
> > and can be used in all places which use signatures in a data
> > structure. Move and rename the fsp_types.h under the common include
> > header.
> >
> > Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> > ---
> >
> > Changes since v1:
> >     Handled review comments from Simon Glass
>
> (best to mention the changes you made rather than the name of your
> reviewer, since that won't mean much to others)
>

Sure, will keep this in mind henceforth. Thanks.

-sughosh


>
> >
> > Build tested for cougarcanyon2 board which builds the
> > relevant fsp code.
> >
> >  arch/x86/include/asm/fsp/fsp_support.h                      | 3 ++-
> >  .../x86/include/asm/fsp/fsp_types.h => include/signatures.h | 6 +++---
> >  2 files changed, 5 insertions(+), 4 deletions(-)
> >  rename arch/x86/include/asm/fsp/fsp_types.h => include/signatures.h
> (95%)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
>
> >
> > diff --git a/arch/x86/include/asm/fsp/fsp_support.h
> b/arch/x86/include/asm/fsp/fsp_support.h
> > index 29e511415c..3cd3e4fcf5 100644
> > --- a/arch/x86/include/asm/fsp/fsp_support.h
> > +++ b/arch/x86/include/asm/fsp/fsp_support.h
> > @@ -7,11 +7,12 @@
> >  #ifndef __FSP_SUPPORT_H__
> >  #define __FSP_SUPPORT_H__
> >
> > +#include <signatures.h>
> > +
> >  #include <asm/fsp/fsp_bootmode.h>
> >  #include <asm/fsp/fsp_fv.h>
> >  #include <asm/fsp/fsp_hob.h>
> >  #include <asm/fsp/fsp_infoheader.h>
> > -#include <asm/fsp/fsp_types.h>
> >  #include <asm/fsp_arch.h>
> >  #include <asm/fsp/fsp_azalia.h>
> >
> > diff --git a/arch/x86/include/asm/fsp/fsp_types.h b/include/signatures.h
> > similarity index 95%
> > rename from arch/x86/include/asm/fsp/fsp_types.h
> > rename to include/signatures.h
> > index 3d5b17ecf1..4042db1e00 100644
> > --- a/arch/x86/include/asm/fsp/fsp_types.h
> > +++ b/include/signatures.h
> > @@ -4,8 +4,8 @@
> >   * Copyright (C) 2014, Bin Meng <bmeng.cn at gmail.com>
> >   */
> >
> > -#ifndef __FSP_TYPES_H__
> > -#define __FSP_TYPES_H__
> > +#ifndef __SIGNATURES_H__
> > +#define __SIGNATURES_H__
> >
> >  /**
> >   * Returns a 16-bit signature built from 2 ASCII characters.
> > @@ -59,4 +59,4 @@
> >  #define SIGNATURE_64(A, B, C, D, E, F, G, H)   \
> >         (SIGNATURE_32(A, B, C, D) | ((u64)(SIGNATURE_32(E, F, G, H)) <<
> 32))
> >
> > -#endif
> > +#endif /* __SIGNATURES_H__ */
> > --
> > 2.17.1
> >
>