[PATCH v1] x86: tangier: Find proper memory region for relocation

Bin Meng bmeng.cn at gmail.com
Tue Dec 15 14:09:50 CET 2020


Hi Andy,

On Tue, Dec 15, 2020 at 6:04 PM Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> On Mon, Nov 30, 2020 at 01:12:17PM -0700, Simon Glass wrote:
> > On Fri, 27 Nov 2020 at 05:40, Andy Shevchenko
> > <andriy.shevchenko at linux.intel.com> wrote:
> > >
> > > It appears that U-Boot works by luck on Intel Edison board because the amount
> > > of RAM is less than 1 GB and standard way of calculating the top of it work
> > > for this configuration. However, this won't work if the amount of RAM is
> > > different and split differently in address space. We have to fine the suitable
> > > window correctly.
> > >
> > > Find proper memory region for relocation by scanning MMAP SFI table in
> > > board_get_usable_ram_top() callback.
> > >
> > > According to the address map documentation the Main Memory is guaranteed to lie
> > > in the 0..2 GB range, that's why we limit search by this range.
> > >
> > > Fixes: e71de54a4943 ("x86: Add Intel Tangier support")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > > ---
> > >  arch/x86/cpu/tangier/sdram.c | 43 ++++++++++++++++++++++++++++++++++++
> > >  1 file changed, 43 insertions(+)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Thanks!
>
> Bin, can we get this, somehow important fix, into v2021.01 release?
> And any comments about the rest tangier/edison patches?
>

Sure, I will take a look soon.

Regards,
Bin


More information about the U-Boot mailing list