[PATCH v2 6/7 RESEND] cmd: button: store button state in the 'button' env

[Heinrich Schuchardt]

On 12/15/20 5:54 PM, Marek Szyprowski wrote:
> Save examined button state in 'button' environment variable to enable
> checking button state in the scripts.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
> ---
> Resend reason: get rid of the Change-Id tag, that was still in v2.
> ---
>   cmd/button.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/cmd/button.c b/cmd/button.c
> index 64c5a8fa04..8da911068a 100644
> --- a/cmd/button.c
> +++ b/cmd/button.c
> @@ -23,8 +23,10 @@ static int show_button_state(struct udevice *dev)
>   	ret = button_get_state(dev);
>   	if (ret >= BUTTON_COUNT)
>   		ret = -EINVAL;
> -	if (ret >= 0)
> +	if (ret >= 0) {
>   		printf("%s\n", state_label[ret]);
> +		env_set("button", state_label[ret]);

Using a hard coded environment variable does not make much sense to me.
The button command has a return value. So just use

button mybutton; setenv myvar $?

Best regards

Heinrich

> +	}
>
>   	return ret;
>   }
>