[PATCH 7/8] spl: fit: Replace #ifdef blocks with more readable constructs

Simon Glass sjg at chromium.org
Sat Dec 19 03:29:06 CET 2020


On Tue, 15 Dec 2020 at 17:10, Alexandru Gagniuc <mr.nuke.me at gmail.com> wrote:
>
> Use the IS_ENABLED() macro to control code flow, instead of the
> caveman approach of sprinkling #ifdefs. Code size is not affected, as
> the linker garbage-collects unused functions. However, readability is
> improved significantly.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
> ---
>  common/spl/spl_fit.c | 53 ++++++++++++++++++++------------------------
>  1 file changed, 24 insertions(+), 29 deletions(-)

I am trying to imagine stick drawings with #ifdefs

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list