[PATCH] i2c: mxc_i2c: improve error message readability

Fabio Estevam festevam at gmail.com
Sat Dec 19 15:49:03 CET 2020


Hi Marc,

On Sat, Dec 19, 2020 at 11:27 AM <ferlandm at amotus.ca> wrote:
>
> From: Marc Ferland <ferlandm at amotus.ca>
>
> Signed-off-by: Marc Ferland <ferlandm at amotus.ca>
> ---
>  drivers/i2c/mxc_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
> index 7609594bd0..d486dab043 100644
> --- a/drivers/i2c/mxc_i2c.c
> +++ b/drivers/i2c/mxc_i2c.c
> @@ -954,7 +954,7 @@ static int mxc_i2c_probe(struct udevice *bus)
>                     !dm_gpio_is_valid(&i2c_bus->scl_gpio) ||
>                     ret || ret2) {
>                         dev_err(bus,
> -                               "i2c bus %d at %lu, fail to request scl/sda gpio\n",
> +                               "i2c bus %d at 0x%2lx, fail to request scl/sda gpio\n",

The change looks good.

I would suggest adding a commit message though.

Thanks


More information about the U-Boot mailing list