[PATCH v2 5/7] IOMUX: Refactor iomux_doenv() in order to increase readability

Andy Shevchenko andriy.shevchenko at linux.intel.com
Mon Dec 21 13:04:32 CET 2020


On Fri, Dec 18, 2020 at 07:29:21PM -0700, Simon Glass wrote:
> On Wed, 16 Dec 2020 at 16:16, Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> >
> > Refactor iomux_doenv() a bit in order to increase readability.
> > There is no change in code generation on x86.

...

> Reviewed-by: Simon Glass <sjg at chromium.org>

Thanks!

...

> event better:
> 
> if (temp)

I didn't get this. Can you elaborate what exactly you had in mind?
Because...

> > +               temp = strchr(temp, ',');
> > +               if (temp == NULL)

...here is a new code.

> > +                       break;
> > +
> > +               temp++;


Since you gave Rb tag I'll leave as is for now.

-- 
With Best Regards,
Andy Shevchenko




More information about the U-Boot mailing list