[PATCH v2 4/6] ARM: dts: s700: add MMC/SD controller node

[André Przywara]

On 22/12/2020 23:28, Jaehoon Chung wrote:
> On 12/19/20 11:51 PM, Amit Singh Tomar wrote:
>> From: Amit Singh Tomar <amittomer25 at gmail.com>
>>
>> This patch adds node for ethernet controller found on Action Semi OWL
>> S700 SoC.
> 
> Is "ethernet controller" right?
> 
>>
>> Since, upstream Linux binding has not been merged for S700 MMC/SD
>> controller, Changes are put in u-boot specific dtsi file.
>>
>> Signed-off-by: Amit Singh Tomar <amittomer25 at gmail.com>
>> ---
>> Changes since previous version
>> 	* No change.
>> ---
>>  arch/arm/dts/s700-u-boot.dtsi | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/dts/s700-u-boot.dtsi b/arch/arm/dts/s700-u-boot.dtsi
>> index 1b27682..3c3396b 100644
>> --- a/arch/arm/dts/s700-u-boot.dtsi
>> +++ b/arch/arm/dts/s700-u-boot.dtsi
>> @@ -19,6 +19,16 @@
>>  			status = "okay";
>>                  };
>>  
>> +		mmc0: mmc at e0210000 {
>> +			compatible = "actions,s700-mmc", "actions,owl-mmc";
> 
> Not need to add both..

We *do* need to have both:
a) it's good style to list "chip-specific", "generic-compatible-model"
for a certain SoC. This allows to later cover bugs or enhancements
without changing the DT.
b) it's what Linux will get
c) it's already the documented binding:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mmc/owl-mmc.yaml

Cheers,
Andre

> 
>> +			reg = <0x0 0xe0210000 0x0 0x4000>;
>> +			interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&cmu CLK_SD0>;
>> +			dmas = <&dma 2>;
>> +			dma-names = "mmc";
>> +			bus-width = <4>;
>> +			status = "okay";
>> +		};
>>  	};
>>  };
>>  
>>
>