patman regression?

[Bin Meng]

Hi Simon,

On Sat, Dec 12, 2020 at 12:29 AM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Bin,
>
> On Thu, 10 Dec 2020 at 21:37, Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson <seanga2 at gmail.com> wrote:
> > >
> > > On 12/10/20 11:27 PM, Bin Meng wrote:
> > > > On Fri, Dec 11, 2020 at 12:08 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> > > >>
> > > >> Hi Simon,
> > > >>
> > > >> The following command no longer works. They used to work.
> > > >>
> > > >> $ ./tools/patman/patman -n -c1
> > > >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT]
> > > >>                [-P PATCHWORK_URL] [-s START] [-v] [-H]
> > > >>                {send,test,status} ...
> > > >> patman: error: unrecognized arguments: -n
> > > >> $ ./tools/patman/patman -n -c 1
> > > >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT]
> > > >>                [-P PATCHWORK_URL] [-s START] [-v] [-H]
> > > >>                {send,test,status} ...
> > > >> patman: error: argument -c/--count: invalid int value: 'send'
> > > >>
> > > >> I did not run a bisect to locate which commit introduced this. Do you
> > > >> have any idea?
> > > >
> > > > Resetting to v2020.10, patman works again with the above 2 commands.
> > > >
> > > > Note the latest patman also throws an exception about commit tags
> > > > while the v2020.10 version did not.
> > > >
> > > > Traceback (most recent call last):
> > > >    File "./tools/patman/patman", line 177, in <module>
> > > >      control.send(args)
> > > >    File "./tools/patman/control.py", line 177, in send
> > > >      args.smtp_server)
> > > >    File "./tools/patman/control.py", line 136, in email_patches
> > > >      add_maintainers, limit)
> > > >    File "./tools//patman/series.py", line 264, in MakeCcFile
> > > >      raise_on_error=raise_on_error)
> > > >    File "./tools//patman/gitutil.py", line 383, in BuildEmailList
> > > >      raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
> > > >    File "./tools//patman/gitutil.py", line 588, in LookupEmail
> > > >      raise ValueError(msg)
> > > > ValueError: Alias 'doc' not found
> > >
> > > I also get this error even with process_tags=False.
> >
> > Yep, here is my patman settings:
> >
> > [settings]
> > ignore_errors: True
> > process_tags: False
> > verbose: True
>
> That error has always been, or nearly. Use -t to drop it. I have been

No, it was not in v2020.10 release.

> thinking about changing it to a warning, since even I am not that
> strict about adding tags to my .patman file these days.
>
> Re the problem you reported, I changed patman to accept a subcommand
> at some point, so you need:
>
> patman  -c1 send -n

If "send" is omitted, the behavior should be like what was like before
in v2020.10, instead of error messages.

> I know this is pretty annoying, so if you have any ideas on how to get
> patman to do the right thing when 'send' is missing, let me know.

If changing the logic is hard, the patman documentation should be
corrected to match the latest command line options.

Regards,
Bin