[PATCH 3/6] efi_loader: Replace config option with EFI variable for initrd loading

Ilias Apalodimas ilias.apalodimas at linaro.org
Mon Dec 28 23:03:57 CET 2020


Hi Heinrich, 

On Mon, Dec 28, 2020 at 03:55:49PM +0100, Heinrich Schuchardt wrote:
[...]
> >   		ret = try_load_entry(bootorder[i], handle, load_options);
> > -		if (ret == EFI_SUCCESS)
> > +		if (ret == EFI_SUCCESS) {
> > +			if (IS_ENABLED(CONFIG_EFI_LOAD_FILE2_INITRD))
> > +				ret = efi_initrd_register();
> 
> I think this is not enough.
> 
> * We should uninstall the protocol once 'bootefi bootmgr' returns
>   to U-Boot.
> * The EFI_LOAD_FILE2_PROTOCOL should be installed on the handle of
>   the loaded image for this purpose.
> 

Yep you are right. I completely missed that case, I'll fix it on v2

Regards
/Ilias
 


More information about the U-Boot mailing list