[PATCH] common: board_f: fix to display wrong memory information

Jaehoon Chung jh80.chung at samsung.com
Wed Dec 30 01:05:52 CET 2020


On 12/30/20 8:48 AM, Sean Anderson wrote:
> On 12/29/20 6:24 PM, Jaehoon Chung wrote:
>> When run meminfo command, it's displayed wrong memory information.
>> Because it's using gd->ram_size what didn't configure ram size.
> 
> what -> which?

Will update

> 
>>
>> On 4G RPI4 target
>> - Before
>>     U-Boot> meminfo
>>     DRAM: 948MiB
>> - After
>>     U-Boot> meminfo
>>     DRAM: 3.9GiB
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
>> ---
>>   common/board_f.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/common/board_f.c b/common/board_f.c
>> index 9f441c44f176..96c675ea28e4 100644
>> --- a/common/board_f.c
>> +++ b/common/board_f.c
>> @@ -228,6 +228,7 @@ static int show_dram_config(void)
>>       }
>>       debug("\nDRAM:  ");
>>   +    gd->ram_size = size;
> 
> Shouldn't this be set by dram_init?

Yes, it's set by dram_init(), I didn't think about only rpi's problem.
I will check other target. (I have checked only RPI..) Thanks for pointing out.

Best Regards,
Jaehoon Chung

> 
> --Sean
> 
>>       print_size(size, "");
>>       board_add_ram_info(0);
>>       putc('\n');
>>
> 
> 



More information about the U-Boot mailing list